Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Limit CMake threads to fix crash compiling libz-ng-sys on macOS #14715

Merged
merged 3 commits into from
Feb 27, 2024
Merged

ci: Limit CMake threads to fix crash compiling libz-ng-sys on macOS #14715

merged 3 commits into from
Feb 27, 2024

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Feb 27, 2024 •
edited
Loading

Presumably spawned too many threads

  make[2]: *** read jobs pipe: Resource temporarily unavailable.  Stop.

@nameexhaustion nameexhaustion changed the title c build on macos Feb 27, 2024
@github-actions github-actions bot added the build Changes that affect the build system or external dependencies label Feb 27, 2024
@nameexhaustion nameexhaustion changed the title build on macos poc build on macos Feb 27, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 27, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.07%. Comparing base (0e63403) to head (4e0f7a2).
Report is 24 commits behind head on main.

❗ Current head 4e0f7a2 differs from pull request most recent head 73f7cee. Consider uploading reports for the commit 73f7cee to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #14715      +/-   ##
==========================================
+ Coverage   80.92%   81.07%   +0.14%     
==========================================
  Files        1328     1322       -6     
  Lines      173446   171348    -2098     
  Branches     2455     2460       +5     
==========================================
- Hits       140369   138915    -1454     
+ Misses      32605    31963     -642     
+ Partials      472      470       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@c-peters c-peters mentioned this pull request Feb 27, 2024
Closed
@nameexhaustion nameexhaustion changed the title poc build on macos build(rust): Limit cmake threads to fix crash compiling libz-ng-sys on macOS Feb 27, 2024
@github-actions github-actions bot added the rust Related to Rust Polars label Feb 27, 2024
@nameexhaustion nameexhaustion changed the title build(rust): Limit cmake threads to fix crash compiling libz-ng-sys on macOS build(rust): Limit CMake threads to fix crash compiling libz-ng-sys on macOS Feb 27, 2024
@nameexhaustion nameexhaustion marked this pull request as ready for review February 27, 2024 12:21
@nameexhaustion nameexhaustion changed the title build(rust): Limit CMake threads to fix crash compiling libz-ng-sys on macOS ci: Limit CMake threads to fix crash compiling libz-ng-sys on macOS Feb 27, 2024
@github-actions github-actions bot added internal An internal refactor or improvement python Related to Python Polars labels Feb 27, 2024
stinodego
stinodego reviewed Feb 27, 2024
View reviewed changes
Copy link
Member

@stinodego stinodego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix!

So is this an issue with libz-ng-sys? If so, is there an issue in their repo we can point to in the comments rather than this PR?

@nameexhaustion
Copy link
Collaborator Author

So is this an issue with libz-ng-sys? If so, is there an issue in their repo we can point to in the comments rather than this PR?

Not entirely sure, and I don't see anything related in their issues yet.. (if this is the right place https://github.com/rust-lang/libz-sys/issues?q=sort%3Aupdated-desc). I won't be able to make a repro as well since I don't own a mac 🫠

@stinodego
Copy link
Member

All right. I made a minor adjustment by only setting this environment variable for the MacOS release flow. Good to merge 👍

@stinodego stinodego merged commit b4ed30b into pola-rs:main Feb 27, 2024
2 checks passed
@nameexhaustion nameexhaustion deleted the darwin branch February 27, 2024 13:37
@eitsupi eitsupi mentioned this pull request Feb 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stinodego stinodego stinodego approved these changes

@ritchie46 ritchie46 Awaiting requested review from ritchie46 ritchie46 is a code owner

@c-peters c-peters Awaiting requested review from c-peters c-peters is a code owner

Assignees
No one assigned
Labels
build Changes that affect the build system or external dependencies internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nameexhaustion @stinodego